Wrap the response in a future when the property :async-future is set #527
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rymndhng
force-pushed
the
async-future-3.x-v2
branch
from
e0bfa2d to
28efb3f
Compare
rymndhng
force-pushed
the
normalize-async-api-for-request
branch
from
4f61aeb to
52cde30
Compare
The existing :async option returns a future of org.apache.http.HttpResponse, which is not the ideal type for Clojurists. This new option :async-future returns a future of a clj-http response.
rymndhng
force-pushed
the
async-future-3.x-v2
branch
from
28efb3f to
c6729a4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #512 Depends on #526